setupWindowHooks parameter to include context for better window management#1
Open
charanjit-singh wants to merge 1 commit intoGridminder:mainfrom
Open
setupWindowHooks parameter to include context for better window management#1charanjit-singh wants to merge 1 commit intoGridminder:mainfrom
charanjit-singh wants to merge 1 commit intoGridminder:mainfrom
Conversation
…ile from being tracked fix(README.md): update setupWindowHooks parameter to include context for better window management refactor(setupWindowRouter.ts): modify setupWindowHooks to accept context parameter for enhanced functionality
charanjit-singh
changed the title
Bram-Zijp
requested changes
Sep 26, 2025
| build | ||
| out No newline at end of file | ||
| out | ||
| pnpm-lock.yaml No newline at end of file |
Contributor
There was a problem hiding this comment.
Sorry I missed the notification of this pull request and haven't looked at it in a while. The pnpm-lock.yaml should not be gitignored. By committing this, the package versions remain stable unless you manually bump them. This also adds security as it contains the module package hashes. When hackers push to an pre-existing version, this hash will prevent it from getting automatically installed as the hash would be changed.
| return { action: 'deny' }; | ||
| }); | ||
|
|
||
| console.log(context); // To get the window config and id |
Contributor
There was a problem hiding this comment.
I don't mind this change but I would be interested in knowing the use-case for the context here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(README.md): update setupWindowHooks parameter to include context for better window management
refactor(setupWindowRouter.ts): modify setupWindowHooks to accept context parameter for enhanced functionality